WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xenpaging: Open paging file only if xenpaging_init()

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xenpaging: Open paging file only if xenpaging_init() succeeds
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Tue, 10 Aug 2010 10:54:42 +0200
Delivery-date: Tue, 10 Aug 2010 01:55:55 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1281430493; l=1187; s=domk; d=aepfle.de; h=Content-Type:MIME-Version:Subject:To:From:Date:X-RZG-CLASS-ID: X-RZG-AUTH; bh=N8J+KyCdNlGqMVg6Z3GVz8QK7Zs=; b=Rz26KfoKCSZMKKX1tRHYgv/pRf6gtAF3aqyC/T5gjTvEecPYwfBKOA8tPocDqMg+TYC UWnUnVx+agQjNOEbakQwcBGqF3F/pkqOqsNPVMK4iOwRZ1Ax3FCFgHAVF8VGzayuNFa9K 7OWl0ViBs4nRQIyUOX5unFBaYL/fgRpGEVs=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
Open paging file only if xenpaging_init() succeeds.
It can fail if the host does not support the required virtualization features 
such as EPT.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

---
 tools/xenpaging/xenpaging.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

--- xen-unstable.hg-4.1.21890.orig/tools/xenpaging/xenpaging.c
+++ xen-unstable.hg-4.1.21890/tools/xenpaging/xenpaging.c
@@ -499,15 +499,6 @@ int main(int argc, char *argv[])
 
     victims = calloc(num_pages, sizeof(xenpaging_victim_t));
 
-    /* Open file */
-    sprintf(filename, "page_cache_%d", domain_id);
-    fd = open(filename, open_flags, open_mode);
-    if ( fd < 0 )
-    {
-        perror("failed to open file");
-        return -1;
-    }
-
     /* Seed random-number generator */
     srand(time(NULL));
 
@@ -519,6 +510,15 @@ int main(int argc, char *argv[])
         goto out;
     }
 
+    /* Open file */
+    sprintf(filename, "page_cache_%d", domain_id);
+    fd = open(filename, open_flags, open_mode);
+    if ( fd < 0 )
+    {
+        perror("failed to open file");
+        return -1;
+    }
+
     /* Evict pages */
     memset(victims, 0, sizeof(xenpaging_victim_t) * num_pages);
     for ( i = 0; i < num_pages; i++ )

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xenpaging: Open paging file only if xenpaging_init() succeeds, Olaf Hering <=