This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3/3]: xl: allow long listing of Domain 0'

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/3]: xl: allow long listing of Domain 0'
From: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Date: Mon, 9 Aug 2010 18:08:21 +0100
Cc: Andre Przywara <andre.przywara@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Keir, Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
Delivery-date: Mon, 09 Aug 2010 10:12:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1008091710100.2545@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C6008DD.4040306@xxxxxxx> <alpine.DEB.2.00.1008091710100.2545@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2010-08-09 at 17:11 +0100, Stefano Stabellini wrote:
> On Mon, 9 Aug 2010, Andre Przywara wrote:
> > Hi,
> > 
> > currently xl list aborts when one tries to list -l Domain 0 (either 
> > explicitly or by listing all domains):
> > # xl list -l 0
> > Neither kernel nor bootloader specified
> > 
> > Ignore this error message (which is invalid for Dom0). I haven't found 
> > an obvious way to check for Dom0 before printing this message, so I 
> > simply removed the exit() call here.
> > 
> I would rather skip dom0 in the list_domains_details loop, I'll apply a
> patch that does that.

FWIW I think that's the wrong fix. The config parser code ought not be
the place to check for such things and should be handled in libxl (or
perhaps elsewhere in xl) with reasonable error message. Seems like a
work-around rather than a fix to not print dom0 info.

Xen-devel mailing list