This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 2/3]: xl: tell the user non-existent domain er

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/3]: xl: tell the user non-existent domain er
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 9 Aug 2010 17:12:05 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Yang Hongyang <yanghy@xxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 09 Aug 2010 09:12:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C6008CA.7030801@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C6008CA.7030801@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Mon, 9 Aug 2010, Andre Przywara wrote:
> Hi,
> the error message when one wants to list a non-existent domain is at 
> best misleading (libxl_domain_info failed (code -5)). Attached patch 
> catches this specific error and tells the user that the requested domain 
> does not exist:
> # xl list 42
> Error: Domain '42' does not exist.

applied, thanks.

> I am not sure whether one should change the default error message in 
> find_domain(), too, which currently reads:
> # xl list foo
> foo is an invalid domain identifier (rc=-1)

I think the error message for find_domain is not too bad

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>