This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 02/14] Nested Virtualization: localevent

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 02/14] Nested Virtualization: localevent
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 6 Aug 2010 15:02:11 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 06 Aug 2010 07:03:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201008061117.33675.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acs1SEr0YYEjVAN0R86jtcvvqTR+GwAJ6vyz
Thread-topic: [Xen-devel] [PATCH 02/14] Nested Virtualization: localevent
User-agent: Microsoft-Entourage/
On 06/08/2010 10:17, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> For this reason, nestedhvm_vcpu_destroy() (added in patch 5/14)
> does a nestedsvm_vcpu_stgi() to prevent the interrupts/events
> from being blocked by hvm_interrupt_blocked() (see patch 9/14)
> and level 1 guest remaining in a zombie state.

Ah, this is the crux of it. You shouldn't need to stgi from the vcpu
destructor. It makes no sense and doing it shouldn't leave you with a zombie
domain. Indeed, vcpu_destroy() is called from the very final domain
destructor -- vcpu_destroy's caller finishes by freeing the domain structure
itself, so not much chance of hanging around as a zombie! I'm assuming you
call nestedhvm_vcpu_destroy() on the vcpu_destroy() path here by the way...
If it's called from some other context then I think its name is misleading
and should be changed.

 -- Keir

Xen-devel mailing list