WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxl: Allow PV guests to add a PCI device witho

To: Mihir Nanavati <mihirn@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: Allow PV guests to add a PCI device without an IOMMU
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Tue, 3 Aug 2010 17:10:35 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Tue, 03 Aug 2010 09:10:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTi=xa8V1S=9UbM_1+D0eDwX-PgPAPX6d6fhKe661@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTimEK-iQ6Btrd3qo2Qpoohj359T=Y40pSiVinNkd@xxxxxxxxxxxxxx> <19538.62497.937964.257710@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTi=xa8V1S=9UbM_1+D0eDwX-PgPAPX6d6fhKe661@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 30 Jul 2010, Mihir Nanavati wrote:
> Stylistically, I'd be happy to follow any suggestions you have - would
> just switching it to
> errno != ENOSYS be sufficient?
> 
> I think the content is ok - in HVM it effectively becomes if(rc < 0)
> and in PV guests it becomes if(rc < 0 && errno != ENOSYS) which should
> be correct. Or am I missing something?
> 

I think the patch is correct, I'll apply it fixing the style.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH] libxl: Allow PV guests to add a PCI device without an IOMMU, Stefano Stabellini <=