WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/2] libxl: const-correctness for libxl_uuid2stri

To: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/2] libxl: const-correctness for libxl_uuid2string
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 30 Jul 2010 14:50:02 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 30 Jul 2010 06:50:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1280424691-15884-1-git-send-email-ian.jackson@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1280424691-15884-1-git-send-email-ian.jackson@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2010-07-29 at 18:31 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Looks ok to me.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxl/libxl.h     |    2 +-
>  tools/libxl/libxl_dom.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 191d1e1..3391491 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -360,7 +360,7 @@ int libxl_run_bootloader(libxl_ctx *ctx,
>                           libxl_device_disk *disk,
>                           uint32_t domid);
>  
> -char *libxl_uuid2string(libxl_ctx *ctx, uint8_t uuid[16]);
> +char *libxl_uuid2string(libxl_ctx *ctx, const uint8_t uuid[16]);
>    /* 0 means ERROR_ENOMEM, which we have logged */
>  
>  /* events handling */
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index b7ee27c..20a16e6 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -427,7 +427,7 @@ int save_device_model(libxl_ctx *ctx, uint32_t domid, int 
> fd)
>      return 0;
>  }
>  
> -char *libxl_uuid2string(libxl_ctx *ctx, uint8_t uuid[16]) {
> +char *libxl_uuid2string(libxl_ctx *ctx, const uint8_t uuid[16]) {
>      char *s = string_of_uuid(ctx, uuid);
>      if (!s) XL_LOG(ctx, XL_LOG_ERROR, "cannot allocate for uuid");
>      return s;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>