This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] libxl: move blktap-specific code into libxl_

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] Re: [PATCH] libxl: move blktap-specific code into libxl_blktap.c
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Fri, 30 Jul 2010 10:45:17 +0200
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 30 Jul 2010 01:46:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201007301040.28331.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201007201831.21416.Christoph.Egger@xxxxxxx> <19537.49697.129250.664039@xxxxxxxxxxxxxxxxxxxxxxxx> <201007301040.28331.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.10
On Friday 30 July 2010 10:40:27 Christoph Egger wrote:
> On Thursday 29 July 2010 20:02:09 Ian Jackson wrote:
> > Christoph Egger writes ("[PATCH] libxl: move blktap-specific code into
> libxl_blktap.c"):
> > > libxl: move blktap-specific code into libxl_blktap.c
> >
> > Except, once again, this is not _pure_ motion.  You need to split the
> > patch up so that, in the code motion patch,
> >
> >   diff -u <(hg diff tools/libxl/libxl.c | perl -pe 's/^[-+]/ $& eq "-" ?
> > "+" : "-" /e' ) <(hg diff tools/libxl/libxl_blktap.c)
> >
> > doesn't produce any substantive output.
> I'm sorry, I don't know perl. And this command fails with syntax error: '('
> unexpected.
> I haven't send the patch yesterday.

Wanted to say: I haven't send the patch with the change yesterday.

> It was late for me. 
> You seem to respond always in the late afternoon (CEST).
> In which timezone are you ?
> Christoph

---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list