[Xen-devel] Re: [PATCH] xenpaging: correct order of linker optio

To:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] xenpaging: correct order of linker options to avoid link errors with recent toolchains
From:	Olaf Hering <olaf@xxxxxxxxx>
Date:	Wed, 28 Jul 2010 18:15:24 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Wed, 28 Jul 2010 09:16:22 -0700
Dkim-signature:	v=1; a=rsa-sha1; c=relaxed/relaxed; t=1280333729; l=675; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=KPoNNjXve70Mpb76YI1iabKWxn4=; b=UD/1Ob5nmEwR16noPuPZKIMgloVdaiiA/Ultic2+1v0n6n224hSWkN8HiHLLK0hBGqg Z2iQjTGREqQFLPrSVK1J1pj/s+Eijh7kzBsJg5ThyXZPVDMbTVLBN+rER0bB1DbALIdem 8fZgqsR9mrErmJ+o6QwriCsRUakMl+qkiSM=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<19536.21860.12916.94743@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20100728125517.GB1949@xxxxxxxxx> <19536.14440.565355.587038@xxxxxxxxxxxxxxxxxxxxxxxx> <20100728154750.GA6899@xxxxxxxxx> <19536.21860.12916.94743@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.20 (2009-06-14)

On Wed, Jul 28, Ian Jackson wrote:

> Olaf Hering writes ("[PATCH] xenpaging: correct order of linker options to 
> avoid link errors with recent toolchains"):
> > -LDFLAGS  += $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore)
> > +XENPAGING_LIBS = $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore)
> 
> *_LIBS = $(LDFLAGS_*)  ?
> 
> surely some mistake.

Ian,

LDFLAGS_libxenctrl is defined in tools/Rules.mk and used in several
Makefiles. Are you suggesting to rename these variables and update all
users?

Also, its not clear to me why the place of LDFLAGS matters. In another
thread it was stated that -static may behave different. Whats the reason
for that?

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [PATCH] xenpaging: correct order of linker options to av