WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH]: xl, fix segfault when detaching non-existant di

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH]: xl, fix segfault when detaching non-existant disk
From: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Date: Tue, 27 Jul 2010 17:10:55 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 27 Jul 2010 09:14:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19534.63853.928166.752285@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1280165088.1723.2062.camel@xxxxxxxxxxxxxxxxxxxxxx> <19534.63853.928166.752285@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2010-07-27 at 16:21 +0100, Ian Jackson wrote:
> Gianni Tedesco (3P) writes ("[PATCH]: xl, fix segfault when detaching 
> non-existant disk"):
> >      val = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/backend-id", 
> > diskpath));
> > +    if (!val)
> > +        return ERROR_FAIL;
> 
> This is fine as far as it goes, and I'll apply it, but would you like
> to do the same for all the other unchecked libxl_xs_read calls ? :-)

It's a gigantic piece of work, along with sorting out various memory
leaks. It is on my TODO list :)

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>