WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Error in Xend-API method VM_set_actions_after_cr

To: Jim Fehlig <jfehlig@xxxxxxxxxx>, "Dube, Lutz" <lutz.dube@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Error in Xend-API method VM_set_actions_after_crash [and 1 more messages]
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 27 Jul 2010 16:54:14 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 27 Jul 2010 08:54:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <3958B14F314B884890EEE2F4CCDAB6A601122BDC5527@xxxxxxxxxxxxxxxx>, <4C4EF4F8.5050106@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <3958B14F314B884890EEE2F4CCDAB6A601122BDC5527@xxxxxxxxxxxxxxxx> <4C4EF4F8.5050106@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Dube, Lutz writes ("[Xen-devel] [PATCH] Error in Xend-API method 
VM_set_actions_after_crash"):
> Xend-API defines the method VM_set_actions_after_crash with valid action
> names coredump_and_destroy, coredump_and_restart,... . These values have to
> be converted into internal representation "coredump-destroy", 
> "coredump-restart", ...
> otherwise start of the domain is rejected.
> Same error occurs, if I try to create a VM using the Xend-API with
> actions_after_crash set to coredump_and_destroy.

Thanks, I've applied this patch.

> Could you please apply my patch to xen-4-0-testing, too.

We'll test it in xen-unstable first, and cherry-pick it later.

Jim Fehlig writes ("Re: [Xen-devel] [PATCH] Error in Xend-API method    
VM_set_actions_after_crash"):
> Your patch looks good, although I've not tested it.

Thanks for the review.  I've taken that as an ack of this patch.  For
reference, explicitly writing

 Acked-by: Your Name <email@xxxxxxxxxxx>

is very helpful.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel