This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxl: blktap2 portiblity fixes

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: blktap2 portiblity fixes
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Wed, 21 Jul 2010 10:32:27 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 21 Jul 2010 01:33:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1007201745480.22235@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201007201831.21416.Christoph.Egger@xxxxxxx> <alpine.DEB.2.00.1007201745480.22235@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.10
On Tuesday 20 July 2010 18:46:30 Stefano Stabellini wrote:
> On Tue, 20 Jul 2010, Christoph Egger wrote:
> > Hi!
> >
> > Attached patch moves blktap2 (which is Linux specific) into
> > a linux specific file.
> > Combined with the previous libxl patch, libxl builds again on NetBSD.
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> this patch breaks the build:
> libxenlight.so: undefined reference to `libxl_blktap_enabled'
> libxenlight.so: undefined reference to `libxl_blktap_devpath'
> collect2: ld returned 1 exit status

Oh, I see the problem. The wrong lines are those:

LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o
+LIBXL_OBJS-$(CONFIG_Linux) = libxl_linux.o
+LIBXL_OBJS-$(CONFIG_NetBSD) = libxl_netbsd.o

New corrected version is attached. It also reverts
c/s 21835 as this showed up due to this bug in my tree.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: xen_tools_libxl.diff
Description: Text Data

Xen-devel mailing list