| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers t
At 15:44 +0100 on 09 Jul (1278690260), Jan Beulich wrote:
> >>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> >+ if ( tr.extra_bytes > 28 || tr.event >= 0x1000 )
>
> Couldn't you use TRACE_EXTRA_MAX * sizeof(u32) instead of the
> literal 28?
Indeed I should.
> The literal 0x1000 also doesn't look nice - I'm no sure though
> whether this really is (1 << TRC_SUBCLS_SHIFT).
Yes it is (the guest's not allowed to define the class or subclass of
the trace entry). How about the attached patch instead?
Cheers,
Tim.
--
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)
hvm-op-trace
Description: Text document
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home