This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Serialise some things in top-level Makefile

To: "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Serialise some things in top-level Makefile
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Thu, 08 Jul 2010 08:17:34 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 08 Jul 2010 00:17:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19508.43101.877001.354543@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <19508.43101.877001.354543@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 07.07.10 at 18:16, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> If the top-level Makefile does "make -C tools" before "make -C xen",
> or "make -C stubdom" before "make -C tools", things can go wrong.
> This will also mean that "make dist-tools" should work, if only by
> virtue of building Xen first.
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I disagree to a change like this, the more that I don't see why it
would be needed: Building the tools independently and before
the hypervisor used to work for me quite fine, and if it got broken
recently I think this is what should get fixed.

One may be building hypervisor and tools (and perhaps also
stubdom) with different settings, but that won't work anymore if
a tools build implies a hypervisor one (unless one does a 
"make -C xen clean" first, thus having wasted the time it took
to build the hypervisor a first time).


> diff -r a0f0ae5be814 Makefile
> --- a/Makefile        Tue Jul 06 17:58:37 2010 +0100
> +++ b/Makefile        Wed Jul 07 17:15:00 2010 +0100
> @@ -66,7 +66,7 @@
>       $(MAKE) -C xen install
>  .PHONY: install-tools
> -install-tools: tools/ioemu-dir
> +install-tools: tools/ioemu-dir install-xen
>       $(MAKE) -C tools install
>  .PHONY: install-kernels
> @@ -74,7 +74,7 @@
>       for i in $(XKERNELS) ; do $(MAKE) $$i-install || exit 1; done
>  .PHONY: install-stubdom
> -install-stubdom: tools/ioemu-dir
> +install-stubdom: tools/ioemu-dir install-tools
>       $(MAKE) -C stubdom install
>  ifeq (x86_64,$(XEN_TARGET_ARCH))
>       XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom install-grub
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> http://lists.xensource.com/xen-devel 

Xen-devel mailing list