WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

RE: [Xen-devel] [PATCH] remove useless super page recomputing in ept_set

from [Li, Xin] [Permanent Link][Original]
To: "Li, Xin" <xin.li@xxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] remove useless super page recomputing in ept_set_entry
From: "Li, Xin" <xin.li@xxxxxxxxx>
Date: Wed, 30 Jun 2010 20:13:43 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 30 Jun 2010 05:14:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <FC2FB65B4D919844ADE4BE3C2BB739AD20A20FEC@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AcsXtcHWAxM4gOenTESzxelCuOCLZA==> <FC2FB65B4D919844ADE4BE3C2BB739AD20A20A22@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTiktEPDYgbcZKokskX39YBm6wW6J2OAkMidQQUGK@xxxxxxxxxxxxxx> <FC2FB65B4D919844ADE4BE3C2BB739AD20A20FEC@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcsYNkXq3AMWsTOKQc2Nn7UfEnK5igAAabBgAAVUQ2A=
Thread-topic: [Xen-devel] [PATCH] remove useless super page recomputing in ept_set_entry 
> > Would it make sense to turn this check on in DEBUG mode?  It can't be
> > that expensive if it's currently on all the time.

But I agree it's ok to add

ASSERT((walk_level == 2) && hvm_hap_has_1gb(d))
ASSERT((walk_level == 1) && hvm_hap_has_2mb(d))

to ept_set_entry.
Thanks!
-Xin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] [PATCH 1 of 1] stubdom hanging at creation, Eric Chanudet
Next by Date:  RE: [Xen-devel] Biweekly VMX status report. Xen: #21669 & Xen0: #b29254..., Xu, Jiajun
Previous by Thread:  RE: [Xen-devel] [PATCH] remove useless super page recomputing in ept_set_entry, Li, Xin
Next by Thread:  [Xen-devel] APIC error during Xen boot, Huang2, Wei
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy