 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl
| To: | Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Wed, 30 Jun 2010 11:19:09 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Wed, 30 Jun 2010 03:20:13 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <201006301212.41002.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcsYPNu5aeKo9XAuRZyjCGFx+YLRFgAANGVH |
| Thread-topic: | [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl |
| User-agent: | Microsoft-Entourage/12.24.0.100205 |
On 30/06/2010 11:12, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote: > On Tuesday 29 June 2010 18:02:54 Keir Fraser wrote: >> How many more of these patches do you have up your sleeve? > > Depends on how small/large the chunks should/may be. > My intention is to remove duplicated rdmsr/wrmsr functions > and make rdmsr usable as a real C function. It's a lot of effort for questionable value isn't it. And many of your patches so far have contained bugs, and in some cases decreased code readability by needing to manually merge/split values to be able to make use of rdmsrl/wrmsrl, so it's not like it's even strictly improving the code. Frankly, it smells like busy work. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: [GIT] netback: drop some more flipping mode stuff, Jeremy Fitzhardinge |
|---|---|
| Next by Date: | RE: [Xen-devel] [PATCH] remove useless super page recomputing in ept_set_entry, Li, Xin |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
