WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] restrict trace buffer MFNs

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] restrict trace buffer MFNs
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Mon, 28 Jun 2010 13:16:42 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 28 Jun 2010 05:18:05 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=qeIbZvbGBqCmAtl6FsXU0gt5E2c0+fX9htWobZ5z6e0=; b=K0uUdlSfW7bDlL3MCVXZXz1FFMu2DDCDTwDZyKm4Cd2PRq0bBLYArX3d89Uetwq+kj nytdCjMHEv0FUHpiJWIry6xAzWNNAAizCkb1GulSuufsGMoqanMcpuom3edaFLv5e4WT 85tu+E1uIOnUtj8gThbyuK9XMWB/YJIB2PDjw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Oa+Jz54SRo08+9pRipwxUYQmJNR7RoLk8geYBfEDc3jo145SYKeQJF2GuSXpYqaWgj FBG107/ycQaeqbcpiiupdNZJGpdauYOAzyxQwVxy4SUE+p4OmoRCR+Jehk0kxyPc0pWY h4S43m9FBG8/QfbXVfGiCJUcj9lSCI5s5KUAk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C2898A5020000780000861A@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C2898A5020000780000861A@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Assuming the runes are correct:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

On Mon, Jun 28, 2010 at 11:42 AM, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
> Since they're being passed to Dom0 using an array of uint32_t, they
> must be representable as 32-bit quantities, and hence the buffer
> allocation must specify an upper address boundary.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>
> --- 2010-06-15.orig/xen/common/trace.c  2010-06-28 11:58:37.000000000 +0200
> +++ 2010-06-15/xen/common/trace.c       2010-06-28 12:16:05.000000000 +0200
> @@ -130,7 +130,8 @@ static int alloc_trace_bufs(void)
>         char         *rawbuf;
>         struct t_buf *buf;
>
> -        if ( (rawbuf = alloc_xenheap_pages(order, 0)) == NULL )
> +        if ( (rawbuf = alloc_xenheap_pages(
> +                order, MEMF_bits(32 + PAGE_SHIFT))) == NULL )
>         {
>             printk("Xen trace buffers: memory allocation failed\n");
>             opt_tbuf_size = 0;
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>