Re: [Xen-devel] [PATCH] tools: fix ia64 build for 21483:779c0ef9682c

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] tools: fix ia64 build for 
21483:779c0ef9682c"):
> This patch fixes ia64 by the following method:
> - rename xc_handle xch
> - rename guest_xc xch
> - add xc_interface *xch to arguments of some functions
> - replace xc_dom_printf with macros

Thanks.  It looks reasonable to me, although I'm not quite sure about
this part:

diff -r a24dbfcbdf69 -r 9480d90c4a1a xen/arch/ia64/xen/dom_fw_domu.c
--- a/xen/arch/ia64/xen/dom_fw_domu.c   Tue Jun 22 07:19:38 2010 +0100
+++ b/xen/arch/ia64/xen/dom_fw_domu.c   Thu Jun 17 16:01:53 2010 +0900
@@ -47,7 +47,11 @@
 #include <asm/dom_fw.h>
 #include <asm/dom_fw_domu.h>
 
+#ifdef __XEN__
 void efi_systable_init_domu(struct fw_tables *tables)
+#else
+void efi_systable_init_domu(xc_interface *xch, struct fw_tables *tables)
+#endif


Keir, do you have an opinion ?  If you're happy with this I'll apply
the whole patch to the tools tree, even though it contains some
changes in xen/include/*64*.  Alternatively, please do apply the whole
patch to your tree right away.


Or, in other words:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel