[Xen-devel] Re: paging_domctl() missing break statements?

To:	Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject:	[Xen-devel] Re: paging_domctl() missing break statements?
From:	Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date:	Wed, 23 Jun 2010 14:27:31 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, 'Keir Fraser' <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date:	Wed, 23 Jun 2010 05:28:33 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=dHaTiAqVaOvFRRwzMhqky77PK8WqeNUVdDw/dM9sB/o=; b=Bh9SwMfwji9Ec95zM9BFvBA+RgbzAI3kv9fJLvrACdBqQfX4de3RZOENHhJBXHDYhq aQP0GfoeqDIJrwiFLq0FBGKQtla4OEXBMIWpyqyHJfcwJvvwpC+0UMGegNikdi5VwO0g XiHLd55WTt3xsOb9gCE71nXXdC4gjDav5cSOU=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=aRUMRmcyU+sinK4cH7C4garmReDgXx6qZgdWfJMmsvi7Zm+frazxl7A71iLaa8nZLs a9qfzpAMKwlGIDdN2+Vg6kqGlnKs/KiMkFw0OaIKLkCeZXsT7g3lmHNQrXw5HWWBKPnS gojmU+uD+ifXLEihFVuZhI+5yO97mFTNeg09Q=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20100217095806.GK368@xxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<4B7BC96F020000780002FC9A@xxxxxxxxxxxxxxxxxx> <20100217095806.GK368@xxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b2pre Thunderbird/3.0.4

On 02/17/2010 10:58 AM, Tim Deegan wrote:

At 09:48 +0000 on 17 Feb (1266400095), Jan Beulich wrote:

The main switch statement in that function looks suspicious, and with no
explicit comment saying that fall-through is intended it would seem like
one or two break statements are actually missing. Comments?


Yep, looks like that was just working by blind luck.

Tim.

diff -r 560277d2fd20 xen/arch/x86/mm/paging.c
--- a/xen/arch/x86/mm/paging.c  Mon Feb 15 08:19:07 2010 +0000
+++ b/xen/arch/x86/mm/paging.c  Wed Feb 17 09:56:43 2010 +0000
@@ -717,11 +717,13 @@
                  hap_logdirty_init(d);
              return paging_log_dirty_enable(d);
          }
+        break;

      case XEN_DOMCTL_SHADOW_OP_OFF:
          if ( paging_mode_log_dirty(d) )
              if ( (rc = paging_log_dirty_disable(d)) != 0 )
                  return rc;
+        break;

      case XEN_DOMCTL_SHADOW_OP_CLEAN:
      case XEN_DOMCTL_SHADOW_OP_PEEK:


This was never applied.

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: paging_domctl() missing break statements?