Re: [Xen-devel] [PATCH 0/3] libflask merging in libxenctrl

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 10:26 +0100 on 22 Jun (1277202415), Vincent Hanquez wrote:
> The following patch series fold libflask into libxenctrl.
> 
> The flask library is small, and putting everything in libxenctrl make
> relying on flask functionalities in libxl easier.

That doesn't sound like a good reason to duplicate a library to me.  
If libxl needs flask functions it should link against them.
Are you volunteering to maintain a fork of a security library?

Tim.

> libflask is left for compatibility purpose, but should be considered
> deprecated, and remove in the near future. all flask_ symbols are now
> xc_flask_ symbols in libxenctrl.
> 
> also remove some code duplication in the add_ and del_ calls.
> 
> Vincent Hanquez (3):
>   merge libflask into libxenctrl
>   remove some duplicated code by having helper add/del functions
>   add flask capabilities in python xc bindings
> 
>  tools/libxc/xc_flask.c            |  357 
> +++++++++++++++++++++++++++++++++++++
>  tools/libxc/xenctrl.h             |   26 +++
>  tools/python/xen/lowlevel/xc/xc.c |  251 ++++++++++++++++++++++++++
>  3 files changed, 634 insertions(+), 0 deletions(-)
> 

Content-Description: ATT00001..txt
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel