WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: Xen-unstable save error

To: "Michal Novotny" <minovotn@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: Xen-unstable save error
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 22 Jun 2010 07:48:34 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 21 Jun 2010 23:49:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C2056C6.2000708@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C8460FA6.18254%keir.fraser@xxxxxxxxxxxxx> <4C2056C6.2000708@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 22.06.10 at 08:23, Michal Novotny <minovotn@xxxxxxxxxx> wrote:
> Jan, as we were solving this with Keir on the list I was unable to save 
> the HVM guest properly and reverting your c/s 21615 helped and with your 
> patch reverted it was working fine. Any idea why there were so type 
> failures for all the pages of HVM guest?

Not really, and I think you will need to find out by instrumenting the
hypercall implementation (XEN_DOMCTL_getpageframeinfo{2,3}) -
really, type failures should only happen for grant frames and I/O
memory pages (as you can see in the code, for the function to
report XTAB either the MFN must be invalid, must be a Xen frame,
or it must be impossible to obtain a reference to the page - all of
which shouldn't hold for the majority of a HVM guest's pages).

Btw., Keir, is it really correct for the type to be returned as zero
(normal page) when xsm_getpageframeinfo() returns non-zero?

Is there anything special about the guest you're trying to save? That
patch was tested quite extensively here before submission...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel