|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
Re: [Xen-devel] [PATCH 06/12] Allow xen platform pci device to be	compil
 
On 06/14/2010 10:20 PM, Konrad Rzeszutek Wilk wrote:
>> -static inline unsigned int max_nr_grant_frames(void)
>> +unsigned int gnttab_max_nr_grant_frames(void)
>>  {
>>      unsigned int xen_max = __max_nr_grant_frames();
>>  
>> @@ -444,6 +445,7 @@ static inline unsigned int max_nr_grant_frames(void)
>>              return boot_max_nr_grant_frames;
>>      return xen_max;
>>  }
>> +EXPORT_SYMBOL_GPL(gnttab_max_nr_grant_frames);
>>     
> Prefix the name with 'xen_' ? That is a mouthfull thought:
>
> Xen Grant Table Max Nr Grant Frames. How about 'xen_gnttab_max_frames' ?
>   
Unfortunately the gnttab API is generally lacking xen_ prefixes.  It's
better to keep this consistent, and then maybe sort them all out together.
    J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread>
 |  
- Re: [Xen-devel] [PATCH 03/12] evtchn delivery on HVM, (continued)
 
 
[Xen-devel] [PATCH 04/12] Xen PCI platform device driver, stefano . stabellini
[Xen-devel] [PATCH 05/12] Add suspend\resume support for PV on HVM	guests., stefano . stabellini
[Xen-devel] [PATCH 06/12] Allow xen platform pci device to be	compiled as a module, stefano . stabellini
[Xen-devel] [PATCH 07/12] Fix find_unbound_irq in presence of	ioapic irqs., stefano . stabellini
[Xen-devel] [PATCH 08/12] Fix possible NULL pointer dereference in	print_IO_APIC, stefano . stabellini
[Xen-devel] [PATCH 09/12] __setup_vector_irq: handle NULL chip_data, stefano . stabellini
[Xen-devel] [PATCH 10/12] Do not try to disable hpet if it hasn't	been initialized before, stefano . stabellini
[Xen-devel] [PATCH 11/12] Use xen_vcpuop_clockevent,	xen_clocksource and xen wallclock., stefano . stabellini
[Xen-devel] [PATCH 12/12] Unplug emulated disks and nics, stefano . stabellini
 |  
  
 | 
    | 
  
  
    |   | 
    |