WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PV-ops][PATCH] Netback: Fix PV network issue for netback

To: "Jeremy Fitzhardinge" <jeremy@xxxxxxxx>, "Dongxiao Xu" <dongxiao.xu@xxxxxxxxx>
Subject: Re: [Xen-devel][PV-ops][PATCH] Netback: Fix PV network issue for netback multiple threads patchset
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Thu, 10 Jun 2010 13:29:31 +0100
Cc: Pasi@xxxxxxxxx, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "djmagee@xxxxxxxxxxxx" <djmagee@xxxxxxxxxxxx>, Fantu <fantonifabio@xxxxxxxxxx>
Delivery-date: Thu, 10 Jun 2010 05:30:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <D5AB6E638E5A3E4B8F4406B113A5A19A1F205536@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <D5AB6E638E5A3E4B8F4406B113A5A19A1F205536@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 10.06.10 at 13:48, "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> wrote:
> Hi Jeremy,
> 
> The attached patch should fix the PV network issue after applying the 
> netback multiple threads patchset.
> 
> This bug comes from the version upgrade when resending my patchset last 
> time. 
> 
> In patch v1 & v2, I used kzalloc() to allocate memory, so there is no 
> problem.
> In patch v3, I changed it to "__get_free_pages(GFP_KERNEL | __GFP_ZERO, 
> order)", so there is also no problem.
> However in patch v4, when modified it to vmalloc according to the comments, 
> memset(0) is missing. Sorry for that.

A perhaps better alternative would be to use

__vmalloc(..., GFP_KERNEL|__GFP_HIGHMEM|__GFP_ZERO, PAGE_KERNEL);

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel