WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] a compile error?

To: "Li, Xin" <xin.li@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] a compile error?
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 10 Jun 2010 10:20:45 +0100
Cc:
Delivery-date: Thu, 10 Jun 2010 02:21:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <FC2FB65B4D919844ADE4BE3C2BB739AD203C4EB2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcsIdsCHml6Nsq7HToOrE4Gt8LHI+QAB3P6E
Thread-topic: [Xen-devel] a compile error?
User-agent: Microsoft-Entourage/12.24.0.100205
On 10/06/2010 09:27, "Li, Xin" <xin.li@xxxxxxxxx> wrote:

> the culprit snip is:
> 
>     if ( unlikely(now - s->next_second_time > SECONDS(86400)) )
>     {
>         dprintk(XENLOG_WARNING, "HVM RTC: dom %u skipping %llu seconds\n",
> ^^^^^^^^^
>                 vrtc_domain(s)->domain_id,
>                 (now - s->next_second_time) / SYSTEM_TIME_HZ);
>         s->next_second_time = now;
>     }
> 
> 
> Should we use PRIu64 here?  I don't know if people using newer gcc don't see
> this as nobody complained.

Fixed by xen-unstable:21590.

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>