WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Linux PATCH] Mark hugepages to the hypervisor to speed

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [Linux PATCH] Mark hugepages to the hypervisor to speed up mapping (with signoff this time)
From: Dave McCracken <dcm@xxxxxxxx>
Date: Wed, 9 Jun 2010 13:20:33 -0500
Cc: Xen Developers List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 09 Jun 2010 11:21:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C0FD790.3070603@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100609172016.19083.9014.sendpatchset@xxxxxxxxxxxxxxxxxxx> <4C0FD790.3070603@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.13.3 (Linux/2.6.32; KDE/4.4.4; x86_64; ; )
On Wednesday, June 09, 2010, Jeremy Fitzhardinge wrote:
> > +             return 1;
> > +     }
> > +     for (i = 0, m = mfn; i < HPAGE_SIZE/PAGE_SIZE; i++, pfn++, m++) {
> > +             if (pfn_to_mfn(pfn) != m) {
> > +                     printk("Guest pages are not properly aligned to use
> > hugepages\n");
> >
> >   
> 
> Isn't this a superset of the previous test?

The code is doublechecking to make sure this hugepage is actually contiguous 
at the machine level.

Dave McCracken
Oracle Corp.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>