| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
RE: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for
|
To: |
Isaku Yamahata <yamahata@xxxxxxxxxxxxx> |
|
Subject: |
RE: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge |
|
From: |
"Kay, Allen M" <allen.m.kay@xxxxxxxxx> |
|
Date: |
Tue, 8 Jun 2010 14:15:34 -0700 |
|
Accept-language: |
en-US |
|
Acceptlanguage: |
en-US |
|
Cc: |
"ian.pratt@xxxxxxxxxxxxx" <ian.pratt@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Han, Weidong" <weidong.han@xxxxxxxxx>, "jean.guyader@xxxxxxxxxx" <jean.guyader@xxxxxxxxxx>, "Ross.Philipson@xxxxxxxxxx" <Ross.Philipson@xxxxxxxxxx> |
|
Delivery-date: |
Tue, 08 Jun 2010 14:15:47 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20100607074551.GB19463@xxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<987664A83D2D224EAE907B061CE93D530114C3D62D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20100607074551.GB19463@xxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcsGFhAy7xaVdLbTSD2EMydC5UudmABN60MA |
|
Thread-topic: |
[Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge |
Isaku,
Thanks for the feedback.
> pci_{read, write}_block() would be better than
> switch(len) case 1: case 2: case4:...
Done!
> Is it really necessary to move PCIBus and PCIBridge to the header file?
> Doesn't pci_bridge_init() work?
I changed to code to utilize pci_bridge_init(). However, I still need to move
PCIBus and PCIBridge defines to the header file. The alternative is to pollute
pc.c with graphics passthrough specific code.
> Overriding pci config read/write methods of i440fx would be much cleaner
> than hooking pci_data_read/write. (pass igd_pci_read/write to
> pci_register_device() in i440fx_init() in hw/piix_pci.c instead of NULL)
Doing this resulted in a lot of duplicated code and also force code path to
change
even when IGD passthrough is not used. To do it correctly, I also need to
put in IGD or PASSTHROGH awareness in piix_pci.c. For now, I'm going to keep
the original patch.
Allen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Kay, Allen M
- Re: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Isaku Yamahata
- RE: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge,
Kay, Allen M <=
- RE: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Stefano Stabellini
- Re: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Isaku Yamahata
- Re: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Stefano Stabellini
- RE: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Kay, Allen M
- Re: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Isaku Yamahata
- RE: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Kay, Allen M
- RE: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge, Stefano Stabellini
|
|
|
| |
|
Home