Gihan Munasinghe writes ("Re: [Xen-devel] syslog support to xentoollog"):
> Great I'll do some patching to get syslog working.
Excellent.
> looking at the xentool.h, following definitions
>
> #define XTL_STDIOSTREAM_SHOW_PID 01u
> #define XTL_STDIOSTREAM_SHOW_DATE 02u
> #define XTL_STDIOSTREAM_HIDE_PROGRESS 04u
>
> I would suggest to be as
> #define XTL_SHOW_PID 01u
> #define XTL_SHOW_DATE 02u
> #define XTL_HIDE_PROGRESS 04u
> So it will be more generic for any loggers that will be implemented
Sure.
Note though that XTL_SHOW_DATE isn't going to be relevant for syslog
since in syslog the date is put in by syslogd.
> also is everyone happy with following loglevel mappings between
> xentoollog_level and syslog
>
> {XTL_DEBUG,LOG_DEBUG},
> {XTL_VERBOSE,LOG_DEBUG},
> {XTL_DETAIL,LOG_DEBUG},
> {XTL_PROGRESS,LOG_DEBUG},
> {XTL_INFO,LOG_INFO},
> {XTL_NOTICE,LOG_NOTICE},
> {XTL_WARN,LOG_WARNING},
> {XTL_ERROR,LOG_ERR},
> {XTL_CRITICAL,LOG_CRIT}
That's probably right.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home