WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] One issue in kill_timer

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] One issue in kill_timer
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Fri, 4 Jun 2010 11:02:36 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Zheng, Shaohui" <shaohui.zheng@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 03 Jun 2010 20:05:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcsDkmHDSVB3NKCMQGKV5VaiJjmRxw==
Thread-topic: One issue in kill_timer
Currently kill_timer assume the timer is either active/inactive. However, 
sometimes caller have called kill_timer already. The latter one may cause crash 
because the timer's list has been delted and cause list_del(&timer->inactive) 
failed. 

BTW, I'm curios why TIMER_STATUS_killed > TIMER_STATUS_inactive? Per my 
understanding, the timer status should be invalid->uninitied->inactive->active 
(heap or list), so IMO TIMER_STATUS_killed should be < TIMER_STATUS_inactive.

Thanks
--jyh


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>