WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xc: deal with xen/evtchn and xen/gntdev device n

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xc: deal with xen/evtchn and xen/gntdev device names
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 1 Jun 2010 08:56:52 +0100
Cc: Bastian Blank <waldi@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 01 Jun 2010 00:57:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C00690B.2020303@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <4C00690B.2020303@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sat, 2010-05-29 at 02:08 +0100, Jeremy Fitzhardinge wrote:
> This patch makes xc_linux properly deal with:
>  1. discovering and creating device nodes if necessary
>  2. the new form of xen/<dev> device names soon to be used by the kernel
> 
> This changes the logic slightly:
>  - If a device node already exists with the proper name, then it uses it
>    as-is, assuming it has already been correctly created.
>  - If the path doesn't exist, or it exists but isn't a device node, and
>    it has successfully found the major/minor for the device, then
>    (re)create the device node.
> 
> Since this logic is identical for gntdev and evtchn, make a common function
> to handle both.

Does any of this logic really belong in libxc in the first place? 

Can we not just rip it all out and make it the distro/platform's
responsibility to ensure these devices exist and are correct? Perhaps
that might involve shipping some default/example udev rules instead.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel