# HG changeset patch # User Tim Deegan # Date 1274798631 -3600 # Node ID a723c31e10d17de54a5cee1024e01f600ba031cd # Parent 7b11ebe91a678090fee7aee6c74e3dd09df27eb7 When a VM's wallclock offset is negative enough, gmtime() can be called with an underflowed uint64, which it then tries to divide into years by subtraction. Handle the input as a 40-bit signed integer instead. Signed-off-by: Tim Deegan diff -r 7b11ebe91a67 -r a723c31e10d1 xen/common/time.c --- a/xen/common/time.c Tue May 25 15:43:46 2010 +0100 +++ b/xen/common/time.c Tue May 25 15:43:51 2010 +0100 @@ -42,6 +42,18 @@ int y; const unsigned short int *ip; + y = 1970; +#ifdef __x86_64__ + /* Allow the concept of time before 1970. 64-bit only; for 32-bit + * time after 2038 seems more important than time before 1970. */ + while ( t & (1UL<<39) ) + { + y -= 400; + t += ((unsigned long)(365 * 303 + 366 * 97)) * SECS_PER_DAY; + } + t &= (1UL << 40) - 1; +#endif + days = t / SECS_PER_DAY; rem = t % SECS_PER_DAY; @@ -53,7 +65,6 @@ tbuf.tm_wday = (4 + days) % 7; if ( tbuf.tm_wday < 0 ) tbuf.tm_wday += 7; - y = 1970; while ( days >= (rem = __isleap(y) ? 366 : 365) ) { ++y;