WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xen: update_runstate_area for 32 bit PV on HVM

To: Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: update_runstate_area for 32 bit PV on HVM guests
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 1 Jun 2010 06:46:11 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 31 May 2010 22:47:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1005281601040.25605@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acr+dkutd885mFjERYiv8TRhJ/ThjAC13Gcb
Thread-topic: [Xen-devel] [PATCH] xen: update_runstate_area for 32 bit PV on HVM guests
User-agent: Microsoft-Entourage/12.24.0.100205
On 28/05/2010 16:01, "Stefano Stabellini" <Stefano.Stabellini@xxxxxxxxxxxxx>
wrote:

>>>  #ifdef CONFIG_COMPAT
>>> -    if ( is_pv_32on64_domain(v->domain) )
>>> +    if ( is_pv_32on64_domain(v->domain) ||
>>> +         (is_hvm_pv_evtchn_domain(v->domain) &&
>>> +          has_32bit_shinfo(v->domain)) )
>>>      {
>>>          struct compat_vcpu_runstate_info info;
>> 
>> Is there any reason why this cannot be just has_32bit_shinfo()?
>> 
>  
> no, actually has_32bit_shinfo should be able to cover all cases

Xen-unstable:21493

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>