This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH]xl: remove duplicate code in migrate_domain()

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH]xl: remove duplicate code in migrate_domain()
From: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
Date: Mon, 31 May 2010 16:56:16 +0800
Delivery-date: Mon, 31 May 2010 01:56:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100423 Thunderbird/3.0.4
libxl_domid_to_name() have already been called in
save_domain_core_begin()->find_domain(), so remove it.

Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx> 

diff -r 96917cf25bf3 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Fri May 28 10:54:07 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c  Tue Jun 01 00:57:11 2010 +0800
@@ -1875,11 +1875,6 @@
     save_domain_core_begin(domain_spec, override_config_file,
                            &config_data, &config_len);
-    if (!common_domname) {
-        common_domname = libxl_domid_to_name(&ctx, domid);
-        /* libxl_domid_to_name fails ?  don't bother with names then */
-    }
     if (!config_len) {
         fprintf(stderr, "No config file stored for running domain and "
                 "none supplied - cannot migrate.\n");

Yang Hongyang

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH]xl: remove duplicate code in migrate_domain(), Yang Hongyang <=