WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xen/netback: Fix null-pointer access in netback_

To: "Bastian Blank" <waldi@xxxxxxxxxx>, "Jan Beulich" <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen/netback: Fix null-pointer access in netback_uevent
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 31 May 2010 09:07:04 +0100
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, James Harper <james.harper@xxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 31 May 2010 01:07:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C0383670200007800004B63@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100527165558.GA11358@xxxxxxxxxxxxxxxxxxxxxxx> <AEC6C66638C05B468B556EA548C1A77D01996BD8@trantor> <AEC6C66638C05B468B556EA548C1A77D01996BDB@trantor> <AEC6C66638C05B468B556EA548C1A77D01996BE0@trantor> <20100528090325.GA13575@xxxxxxxxxxxxxxxxxxxxxxx> <4BFFFD30.6000807@xxxxxxxx> <AEC6C66638C05B468B556EA548C1A77D01996C1F@trantor> <4C005228.5060107@xxxxxxxx> <AEC6C66638C05B468B556EA548C1A77D01996C20@trantor> <20100529064411.GA12168@xxxxxxxxxxxxxxxxxxxxxxx> <20100529184452.GA18365@xxxxxxxxxxxxxxxxxxxxxxx> <4C0383670200007800004B63@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 31.05.10 at 09:37, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
> Furthermore, the backend creation patch also needs adjustment,

... path ...

> as it currently stores a non-NULL non-pointer value in be->netif if
> netif_alloc() fails. To require the sysfs path to use IS_ERR() on

... To *not* require ...

> be->netif, I think netif_alloc()'s result should be stored to a local 
> variable first and only written to be->netif when valid.
 
Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel