This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] xen crash related to pci passthrough

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] xen crash related to pci passthrough
From: Alex Zeffertt <alex.zeffertt@xxxxxxxxxxxxx>
Date: Fri, 28 May 2010 10:28:21 +0100
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Fri, 28 May 2010 02:29:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BFEDDDC.3060904@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C8248E7F.2103%keir.fraser@xxxxxxxxxxxxx> <4BFEDDDC.3060904@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100423 Lightning/1.0b1 Thunderbird/3.0.4
This is only tangentially related, but...

In xen/arch/x86/irq.c:__pirq_guest_unbind() this code looks wrong to me:

    memmove(&action->guest[i], &action->guest[i+1], IRQ_MAX_GUESTS-i-1);

Should it be:

memmove(&action->guest[i], &action->guest[i+1], sizeof(action->guest[0])*(IRQ_MAX_GUESTS-i-1));




On 27/05/10 22:02, Jeremy Fitzhardinge wrote:
On 05/27/2010 01:02 PM, Keir Fraser wrote:
On 27/05/2010 20:51, "Jeremy Fitzhardinge"<jeremy@xxxxxxxx>  wrote:

    3. attach device to PV domU
       dom0# xl pci-attach f13pv64 0000:03:00.0
    4. unbind from pciback
       dom0# echo 0000:03:00.0>  /sys/bus/pci/drivers/pciback/unbind
    5. rmmod driver in domU
       domU# rmmod e1000e
    6. Crash!

The device in question is an Intel 82574L ethernet controller, using
msi-x interrupts.

What happens if you pci-detach before unbinding from pciback? Not that Xen
should crash of course, but a crash resulting from a mistake in detach
ordring in dom0 would be less worrying than some alternatives.

Doing things in a more sensible order (rmmod in domU, detach, unbind)
seems to work OK.  I was deliberately seeing what would happen if I
tried pulling the device out from under a domain.


Xen-devel mailing list

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>