This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] treatment grant frames during save/restore

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] treatment grant frames during save/restore
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 28 May 2010 09:22:06 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 28 May 2010 01:23:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BFF947A0200007800004715@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acr+O/1WGMMrExIDTKK1i5xyoPSgoQAAt5Q/
Thread-topic: [Xen-devel] treatment grant frames during save/restore
User-agent: Microsoft-Entourage/
On 28/05/2010 09:01, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> Wouldn't is suffice to adjust XEN_DOMCTL_getpageframeinfo{2,3} to
> report these pages as special (not sure whether a new type would
> be needed, or whether simply returning XEN_DOMCTL_PFINFO_XTAB
> would be acceptable), thus allowing the tools to skip them as
> necessary? This of course implies that the tools would need to issue
> the call for HVM guests (currently I think they do so only for PV ones),
> that the actual page contents is irrelevant post-restore, and that
> there being a hole in the physical address space post-restore isn't
> a problem for the pv drivers.

Yep that would probably work. And also potentially gets rid of one lot of
"if-hvm-else-pv" branched code in xc_domain_save.c. I'd take a patch to do
that if you want to pick this item up.

 -- Keir

Xen-devel mailing list