Re: [Xen-devel] [PATCH 04/11] Fix find_unbound_irq in presence of ioapic irqs.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, May 24, 2010 at 07:27:30PM +0100, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Can you provide a more detailed description of why this is needed?

> ---
>  drivers/xen/events.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 8b68fc4..1356fa2 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -339,9 +339,18 @@ static int find_unbound_irq(void)
>       int irq;
>       struct irq_desc *desc;
>  
> -     for (irq = 0; irq < nr_irqs; irq++)
> +     for (irq = 0; irq < nr_irqs; irq++) {
> +             desc = irq_to_desc(irq);
> +             /* only 0->15 have init'd desc; handle irq > 16 */
> +             if (desc == NULL)
> +                     break;
> +             if (desc->chip == &no_irq_chip)
> +                     break;
> +             if (desc->chip != &xen_dynamic_chip)
> +                     continue;
>               if (irq_info[irq].type == IRQT_UNBOUND)
>                       break;
> +     }
>  
>       if (irq == nr_irqs)
>               panic("No available IRQ to bind to: increase nr_irqs!\n");
> -- 
> 1.5.4.3
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel