This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]: blktap2 : control function

To: Pasi Kärkkäinen <pasik@xxxxxx>
Subject: Re: [Xen-devel] [PATCH]: blktap2 : control function
From: eXeC001er <execooler@xxxxxxxxx>
Date: Sat, 22 May 2010 01:23:46 +0400
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 21 May 2010 14:24:50 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=hW5pu+QWSytHj4fV32WNJ+2usxhtWG62IvY2Lm3XdcA=; b=d5IoQy3dLTfl1V2MVCSeidr1yHm0w6iOBvJGxkJqiuyZ/w9PYLD3jkfKJtcq4ODp65 PICoJa/zwdKlbIbdVu6gW2WlVne4ot3LNVp2GIHCLaHA6i2qbWwptpa858nzINHZit8c cIfR1C9rXKYifsuPGnmgr8+RIgy9iTgDFfWZA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=nPWHNuw2hMQLJFZbFc+1K+PGodyV93c1rfm45VWS2cmLmU+U0CZo5cyjUcoIwLSPnS yoergRU2EyQYEz4Uu8IEzzqF0/pUXFy82zmvAZ21M4FPcflqklpe41GVBTfyqzIcudw4 HH4dXA3PJKrgsYHOmnsjHqKyAeH2QKAyCe4yQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100521202727.GY17817@xxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTimvs-DX-SNhhSDg7p27csdZX_8NfXHTPpCUE9q5@xxxxxxxxxxxxxx> <20100521202727.GY17817@xxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

with additional

2010/5/22 Pasi Kärkkäinen <pasik@xxxxxx>
On Fri, May 21, 2010 at 08:51:12PM +0400, eXeC001er wrote:
>    Hi.
>    I tried to create small patch for blktap2 : control function:

This patch is horribly broken at least for me.. It looks really weird.
You might want to re-send it in a proper format..

.. Or if it works for others just forget about this rant:)

-- Pasi

>    diff -r 840f269d95fb tools/python/xen/xend/XendDomainInfo.py
>    --- a/tools/python/xen/xend/XendDomainInfo.py   Wed May 19 22:59:52 2010
>    +0100
>    +++ b/tools/python/xen/xend/XendDomainInfo.py   Fri May 21 20:17:15 2010
>    +0400
>    @@ -3292,6 +3292,7 @@
>    Â
>    Â Â  Â  Â  Â  Â  Â  try:
>    + Â  Â  Â  Â  Â  Â  Â  Â time.sleep(5)
>    Â Â  Â  Â  Â  Â  Â  Â  Â  blcfg = bootloader(blexec, fn, self, False,
>    Â Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â bootloader_args,
>    kernel, ramdisk, args)
>    Â Â  Â  Â  Â  Â  Â  finally:
>    @@ -3299,7 +3300,7 @@
>    Â Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  [1]log.info("Unmounting %s from %s." %
>    Â Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â (fn,
>    Â
>    - Â  Â  Â  Â  Â  Â  Â  Â  Â  Â dom0.destroyDevice('tap',
>    + Â  Â  Â  Â  Â  Â  Â  Â  Â  Â dom0.destroyDevice(devtype,
>    Â
>    Â Â  Â  Â  Â  Â  Â  if blcfg is None:
>    Â Â  Â  Â  Â  Â  Â  Â  Â  msg = "Had a bootloader specified, but can't
>    find disk"
>    With this patch DomU boot from VHD disk without error.
>    But i can not fix other bug:
>    if after DomU (boot disk is blktap2-type) stopped i can not start it
>    again, because i get error "raise VmError("Device %s is already
>    connected." % dev_str)" in "DevController.py".
>    but i found workaround:
>    stop blktap2_mount: echo 1 >Â /sys/class/blktap2/blktapX/remove
>    remove records from xenstore:Â
>    xenstore-rm /vm/00000000-0000-0000-0000-000000000000
>    xenstore-write /local/domain/0/vm ""
>    Now i can run my DomU again.
> References
>    Visible links
>    1. http://log.info/

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Attachment: blktap2_control_func.patch
Description: Text Data

Xen-devel mailing list