This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 03/17] vmx: nest: wrapper for control update

To: Qing He <qing.he@xxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 03/17] vmx: nest: wrapper for control update
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 20 May 2010 13:57:18 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 20 May 2010 06:04:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100520094638.GB21042@qhe2-db>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acr4AaUukIV6JNiTT8iOZS8Xa8uoDwAGlUVY
Thread-topic: [Xen-devel] [PATCH 03/17] vmx: nest: wrapper for control update
User-agent: Microsoft-Entourage/
On 20/05/2010 10:46, "Qing He" <qing.he@xxxxxxxxx> wrote:

>> Shouldn't this use the new vmx_update_exception_bitmap()?
> I left it unchanged because it's in vmcs.c. To me, vmx.c is on top of
> vmcs.c and I feel against inter-dependeny.

The pslit between vmx.c and vmcs.c is a bit arbitrary in some cases. But
it's cleaner and more maintainable to have everyone use a single interface
to the exception bitmap if possible.

 -- Keir

> Anyway this feeling is not strong. And I'm fine with using
> vmx_update_exception_bitmap here since inter-dependency is already
> the case.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>