WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] fix save or snapshot at kernel loading time with HVM

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] fix save or snapshot at kernel loading time with HVM vm
From: "James (song wei)" <jsong@xxxxxxxxxx>
Date: Sun, 16 May 2010 22:57:23 -0700 (PDT)
Delivery-date: Sun, 16 May 2010 22:58:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
If doing save or snapshot at the time of kernel loading of a HVN vm,
event_channel haven't been initialized, so that make this saving with
xenstore. a string named "suspend" not "suspended"  will be sent to xend
from checkpoint thread. 
 But in the shutdown function with parameter "suspend" think this request
should shutdown this hvm guest, but obviously, this is not the expectation
of save or  snapshot. 

-James (Song Wei)

Signed-off-by:James (Song Wei) <jsong@xxxxxxxxxx>
diff -r baccadfd9418 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Fri May 14 08:05:05 2010
+0100
+++ b/tools/python/xen/xend/XendDomainInfo.py   Mon May 17 13:56:15 2010
+0800
@@ -530,7 +530,7 @@
         self.storeDom("control/shutdown", reason)
 
         # HVM domain shuts itself down only if it has PV drivers
-        if self.info.is_hvm():
+        if self.info.is_hvm() and reason != 'suspend':
             hvm_pvdrv = xc.hvm_get_param(self.domid,
HVM_PARAM_CALLBACK_IRQ)
             hvm_s_state = xc.hvm_get_param(self.domid,
HVM_PARAM_ACPI_S_STATE)
             if not hvm_pvdrv or hvm_s_state != 0:

-- 
View this message in context: 
http://old.nabble.com/-PATCH--fix-save-or-snapshot-at-kernel-loading-time-with-HVM-vm-tp28579732p28579732.html
Sent from the Xen - Dev mailing list archive at Nabble.com.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>