This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Problem starting stubdoms past a domid of 257 + fix

To: John Weekes <lists.xen@xxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Problem starting stubdoms past a domid of 257 + fix
From: Pasi Kärkkäinen <pasik@xxxxxx>
Date: Sat, 15 May 2010 13:26:05 +0300
Cc: Keir Fraser <keir.fraser@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 15 May 2010 03:26:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <2D06015506BF4089B63E8AC3A3E57A1A@JohnPC>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <2D06015506BF4089B63E8AC3A3E57A1A@JohnPC>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, May 14, 2010 at 03:02:04PM -0700, John Weekes wrote:
>    I'm running Xen 4.0.1-rc1-pre (21122:7d1d4abd8b44). In this version, and
>    in all other Xen 3.5-unstable + versions that I've looked at, is
>    this function in XendDomainInfo.py:
>        def getStubdomDomid(self):
>            dom_list = xstransact.List('/local/domain')
>            for d in dom_list:
>                target = xstransact.Read('/local/domain/' + d + '/target')
>                if target is not None and int(target) is self.domid :
>                    return int(d)
>            return None
>    The bolded line has a bug in it, unfortunately. This function is used in
>    domain destruction, and destruction works properly when a domain has a
>    stubdom, but only until it reaches a domid of around 257. Past that, it
>    breaks. This can be easily seen by simply starting a bunch of HVMs with
>    stubdoms (I tested by creating + destroying the same one, over and over).
>    What's interesting is that the function works at all -- "is" really does
>    not seem to be the right comparator to use here.
>    The fix is to change that line to read:
>                if target is not None and int(target) == self.domid :
>    I have patched all of my existing Xen installs, and tested the fix. This
>    might make a good candidate for inclusion in 4.0.1, as well as
>    xen-unstable (if it has the same piece of code).

You might want to submit an actual patch together with a Signed-off-by line.
See the end of: http://wiki.xensource.com/xenwiki/XenFaq

-- Pasi

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>