This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] new commands "xl reboot" & "xl shutdown"

To: Gihan Munasinghe <GMunasinghe@xxxxxxxxxxxx>, Vincent Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] new commands "xl reboot" & "xl shutdown"
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 13 May 2010 08:41:50 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 13 May 2010 00:42:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BEAE0B0.9040403@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrx9f/qd6ezRaeMR1GGPVMhG5rk8gAeb98k
Thread-topic: [Xen-devel] [PATCH] new commands "xl reboot" & "xl shutdown"
User-agent: Microsoft-Entourage/
On 12/05/2010 18:09, "Gihan Munasinghe" <GMunasinghe@xxxxxxxxxxxx> wrote:

>> the if (/* hvm */ 0) is because the function never properly tested if
>> the domain is hvm or not. nowadays you have is_hvm(domid) function
>> that can handily replace the hardcoded value.
> Yes having is_hvm is much better than the hard coded values I have
> changed that bit of code see attached patch.

Please port your patch to the tip of xen-unstable and re-post with changeset
comment and signed-off-by-line.


Xen-devel mailing list