WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PATCH] dom0 vcpu set problem

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel][PATCH] dom0 vcpu set problem
From: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
Date: Tue, 11 May 2010 11:07:30 +0200
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Tue, 11 May 2010 02:08:09 -0700
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=dietmar.hahn@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1273568505; x=1305104505; h=from:to:subject:date:cc:references:in-reply-to: mime-version:content-transfer-encoding:message-id; z=From:=20Dietmar=20Hahn=20<dietmar.hahn@xxxxxxxxxxxxxx> |To:=20xen-devel@xxxxxxxxxxxxxxxxxxx|Subject:=20Re:=20[Xe n-devel][PATCH]=20dom0=20vcpu=20set=20problem|Date:=20Tue ,=2011=20May=202010=2011:07:30=20+0200|Cc:=20Jan=20Beulic h=20<JBeulich@xxxxxxxxxx>,=0D=0A=20Jeremy=20Fitzhardinge =20<jeremy@xxxxxxxx>|References:=20<201005110819.47801.di etmar.hahn@xxxxxxxxxxxxxx>=20<4BE92223020000780000239C@vp n.id2.novell.com>|In-Reply-To:=20<4BE92223020000780000239 C@xxxxxxxxxxxxxxxxxx>|MIME-Version:=201.0 |Content-Transfer-Encoding:=207bit|Message-Id:=20<2010051 11107.30550.dietmar.hahn@xxxxxxxxxxxxxx>; bh=e5n/lzkS+pS0NrTmwijA9K9Jgg1ecNDHeYXNvh81JtQ=; b=cuWeUPEE916Pzfha96awX5rli2Sl43hVDug0bcyGY1MTAOGLvkM8+7CI 6EzMsvcYDSu3uX0ccy60UaG65ZX6v/jzRZvOn08N4yRNBueBbWUH6g3/i ZGfhB0Kvia30Ak95pFB7acVVNh7BLfFHyqSg/CwfWEcj8ONYPryx2sPGT roaAdaeoXJ50XB1evSFzrfH6Xh+TR3OrxL/pJv1/cm14mZu9eKazcp90p 02QonSSXGi78RJXpex0Qf/yAGVf/B;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:From:To:Subject:Date:User-Agent:Cc: References:In-Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id; b=XKI1nyImznTtyKAX2buxJ1gbBz5RES2qQh+6DECHmn16JnPT/9C10/C3 c8hERq6+oqCPZ12yEVW9Z9NMVEWxzL/UGKs6EitFSD2cNYSPZiu4gHjyD abtKlK/9LxWxu3iJ9v0Id6q8UMbtxwqoBLpvtigHdlpHcHuP7EM/YFNp3 SXZCoTbhCD8BHIMV3dk9YACiJZS/Wv1xBh5I2b8xjeKueld3xKIWUGyuL PkSWqHammH+sDm41zfpJIKaEPiVeI;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BE92223020000780000239C@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201005110819.47801.dietmar.hahn@xxxxxxxxxxxxxx> <4BE92223020000780000239C@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.13.3 (Linux/2.6.31.13-xen-hahn; KDE/4.4.3; x86_64; ; )
Am 11.05.2010 schrieb Jan Beulich:
> >>> Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx> 11.05.10 08:19 >>>
> >Can anybody point me where in the code the acpi cpu hotplug gets triggered to
> >add the vcpu again to the dom0 kernel after setting the xenstore!
> 
> No, ACPI hotplug code is not involved in pv domains' vCPU adding or
> removal. Instead, the pv kernels create a xenstore watch on their
> domain's "cpu" node, reading cpu/<id>/availability when the watch
> fires. See drivers/xen/core/cpu_hotplug.c (for the forward ported
> kernels) or drivers/xen/cpu_hotplug.c (for the pv-ops ones).
> 
> Jan

It's the pv-ops kernel from within the xen-4.0-testing.hg tree.
Thanks, Jan ;-)
Pointing to the right place I found a missing cpu_up() call
in the vcpu_hotplug() function.
Now all my vcpus are back again on my machine ;-)
Thanks.

Dietmar.


Signed-off-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>

diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
index bdfd584..f3f0c1e 100644
--- a/drivers/xen/cpu_hotplug.c
+++ b/drivers/xen/cpu_hotplug.c
@@ -49,6 +49,7 @@ static void vcpu_hotplug(unsigned int cpu)
        switch (vcpu_online(cpu)) {
        case 1:
                enable_hotplug_cpu(cpu);
+               (void)cpu_up(cpu);
                break;
        case 0:
                (void)cpu_down(cpu);


-- 
Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>