Re: [Xen-devel] [Patch] support cpupool for xl create

To:	Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject:	Re: [Xen-devel] [Patch] support cpupool for xl create
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Mon, 10 May 2010 08:58:39 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Mon, 10 May 2010 00:00:11 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1273474803; x=1305010803; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4BE7AE9F.2090900@xxxxxxxxxxxxxx>\|Date:=20 Mon,=2010=20May=202010=2008:58:39=20+0200\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20Jeremy=20Fitzhardinge=20<jeremy@xxxxxxxx> \|CC:=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@lists .xensource.com>\|Subject:=20Re:=20[Xen-devel]=20[Patch]=20 support=20cpupool=20for=20xl=20create\|References:=20<4BE3 CBCA.7080104@xxxxxxxxxxxxxx>=20<4BE48CC7.3050101@xxxxxxxx >=09<4BE7A22C.8020100@xxxxxxxxxxxxxx>=20<4BE7AAF2.50906@g oop.org>\|In-Reply-To:=20<4BE7AAF2.50906@xxxxxxxx> \|Content-Transfer-Encoding:=207bit; bh=1cCHHJIrb9yYoAGzATYeI+pRiw8idCwwrD0/m6InP5M=; b=WnT0aBJOwtmApG0NQoh3kFEMwq+XPQxjUMs51rdgmNyOhZE9fScYEqEa lfuYIwaFHP8vvltY0eyItCAO82Ds22mLzBkUrStAd33uTmjcmuuNIL5kX 0SvnlNUF8rizt6W1u659xej1VEV0xDNEw+MUU3uf/+IR/lomPgj5tSAua O2PjH4MOobEyaWl7hQnQ5Jvc5vvKUgRUgzPs3nvXGxgZkqCoyTZD1vp1E wt9ltoI6RsmP0l5iHp90Gdj6bifHw;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=FwGgfdaYflDHSlDzRSfsAeW3tgN/EXBTwdj8q0s2NRBxjnZM79mGA+PM g+hokUEM+vGiVvfqaE7RH8HgNVUzQNLMscHP5meewDJlIZYhypneECgt0 1lyQ7fSWK5Ozgpb+oM6B7cCoQOU9vDcnpYTrDtaJRe1GZBeEkZtDbN/Uq 1j5a8ehMjkYW9ltdf0yux0MQ9liT0Ox/8dGs/7bLOWp2Xk1FLWdrrWpH6 ecnCnXVJh3vDUS9kjgBMHA9UwEPNt;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4BE7AAF2.50906@xxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<4BE3CBCA.7080104@xxxxxxxxxxxxxx> <4BE48CC7.3050101@xxxxxxxx> <4BE7A22C.8020100@xxxxxxxxxxxxxx> <4BE7AAF2.50906@xxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100411 Iceowl/1.0b1 Icedove/3.0.4

On 05/10/2010 08:42 AM, Jeremy Fitzhardinge wrote:

On 05/09/2010 11:05 PM, Juergen Gross wrote:

diff -r bbf009817ffb tools/libxl/libxl.c
--- a/tools/libxl/libxl.c    Fri May 07 19:22:28 2010 +0100
+++ b/tools/libxl/libxl.c    Fri May 07 14:57:00 2010 -0700
@@ -169,7 +169,8 @@

       xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/uuid", vm_path),
uuid_string, strlen(uuid_string));
       xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/name", vm_path),
info->name, strlen(info->name));
-    xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name",
vm_path), info->poolname, strlen(info->poolname));
+    if (info->poolname)
+        xs_write(ctx->xsh, t, libxl_sprintf(ctx, "%s/pool_name",
vm_path), info->poolname, strlen(info->poolname));

       libxl_xs_writev(ctx, t, dom_path, info->xsdata);
       libxl_xs_writev(ctx, t, libxl_sprintf(ctx, "%s/platform",
dom_path), info->platformdata);

fixes it for me.



You seem to have specified a not existing cpupool.
The solution should not be to ignore this, but to do a proper test on the
pool parameter.
Attached patch does this.


I'm not using cpupools.  My config makes no mention of "pool" at all.


Strange.
I tested this case and it worked for me.
Are you sure you have all actual patches installed?
Could you try "xl create -d" and look for the cpupool settings?

Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [Patch] support cpupool for xl create