This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] svm: Avoid VINTR injection during NMI shadow

To: Wei Wang2 <wei.wang2@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] svm: Avoid VINTR injection during NMI shadow
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 7 May 2010 17:56:32 +0100
Delivery-date: Fri, 07 May 2010 09:57:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201005071641.50013.wei.wang2@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrt86jJyOR0qqO5TE2+JMTdQ0vevAAEpXB+
Thread-topic: [Xen-devel] [PATCH] svm: Avoid VINTR injection during NMI shadow
User-agent: Microsoft-Entourage/
I think the if statement should be:
 if ((vmcb->general1_intercepts & GENERAL1_INTERCEPT_IRET) &&
     (intack.source == hvm_intsrc_nmi))

Which I think deals properly and specifically with this hang problem.

What do you think?

 -- Keir

On 07/05/2010 15:41, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:

> Hi,
> I had observed that if xen injects and intercepts VINTR during NMI shadow, and
> if the xen injects NMI into guest at a very hight frequency, guest vcpu will
> hang. Attached patch avoids VINTR injection when guest is handling a NMI.
> Thanks,
> Wei
> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> Reviewed-by: Wei Huang<wei.huang2@xxxxxxx>
> --
> Legal Information:
> Advanced Micro Devices GmbH
> Karl-Hammerschmidt-Str. 34
> 85609 Dornach b. München
> Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
> Sitz: Dornach, Gemeinde Aschheim, Landkreis München
> Registergericht München, HRB Nr. 43632

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>