Re: [Xen-devel] [PATCH, v2] reduce 'd' debug key's global impact

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 06/05/2010 09:07, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 06.05.10 09:42 >>>
>> Pick something rare like SPURIOUS_APIC_VECTOR. In that particular handler
>> you can even put your check on the unlikely path that checks for and acks a
>> real vectored interrupt.
> 
> Hmm, yes, that's indeed better than the event check one.
> 
> However, I noticed that even without that change on_selected_cpus()
> is being used in interrupt context, hence I wonder whether indeed only
> the new mechanism should be going the call-func-less route.

If you add this new mechanism to call into __dump_execstate() then there is
no reason not to use it for both the 'old' and 'alt' dumping methods. Indeed
doing it for both will avoid needing your hack to the call_function handler
to pass regs when the info parameter is NULL (which I could understand but
was still icky, and I would probably have changed the interface to the
on_selected/each_cpu functions instead).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel