This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH, v2] reduce 'd' debug key's global impact

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH, v2] reduce 'd' debug key's global impact
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 6 May 2010 10:09:21 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 06 May 2010 02:11:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BE294CF0200007800001825@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrs8xCfodfcSnRbRSu+mFe2IOiK+wACL+5A
Thread-topic: [Xen-devel] [PATCH, v2] reduce 'd' debug key's global impact
User-agent: Microsoft-Entourage/
On 06/05/2010 09:07, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 06.05.10 09:42 >>>
>> Pick something rare like SPURIOUS_APIC_VECTOR. In that particular handler
>> you can even put your check on the unlikely path that checks for and acks a
>> real vectored interrupt.
> Hmm, yes, that's indeed better than the event check one.
> However, I noticed that even without that change on_selected_cpus()
> is being used in interrupt context, hence I wonder whether indeed only
> the new mechanism should be going the call-func-less route.

If you add this new mechanism to call into __dump_execstate() then there is
no reason not to use it for both the 'old' and 'alt' dumping methods. Indeed
doing it for both will avoid needing your hack to the call_function handler
to pass regs when the info parameter is NULL (which I could understand but
was still icky, and I would probably have changed the interface to the
on_selected/each_cpu functions instead).

 -- Keir

Xen-devel mailing list