This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]xl: move libxl init functions from xl.c to xl_cmd

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]xl: move libxl init functions from xl.c to xl_cmdimpl.c
From: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
Date: Thu, 06 May 2010 09:12:38 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 05 May 2010 18:12:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19425.39634.19846.441503@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BE0F732.8000005@xxxxxxxxxxxxxx> <19425.39634.19846.441503@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100415 Thunderbird/3.0.4
Hi Ian,

On 05/06/2010 12:20 AM, Ian Jackson wrote:
> Yang Hongyang writes ("[Xen-devel] [PATCH]xl: move libxl init functions from 
> xl.c to xl_cmdimpl.c"):
>> Move libxl init functions from xl.c to xl_cmdimpl.c, use a wrapper function
>> xl_init to do libxl init things.
> I don't understand the purpose of this change.

It's my mistake that uses extern vars in .c file this way, Keir fix part of it, 
but there remains
two declarations in xl.c. My prupose is to correct this usage. But compare to 
move these
declarations to .h file, I prefer move code related to these vars to 
xl_cmdimpl.c, because
I think the libxl init and set log functions is more related to command 

> Ian.

Yang Hongyang

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>