This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] reduce 'd' debug key's global impact

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] reduce 'd' debug key's global impact
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 5 May 2010 10:34:17 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 05 May 2010 02:35:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BE156BE02000078000015FA@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrsNYB3flPADh8oQlmcOdj4CAkxZQAAKErt
Thread-topic: [Xen-devel] [PATCH] reduce 'd' debug key's global impact
User-agent: Microsoft-Entourage/
On 05/05/2010 10:30, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 05.05.10 11:05 >>>
>> I'm not against the 'alt-key' scheme in your '0'-key handler patch. Perhaps
>> you could extend the alt-key principle to the 'd' key, and leave the
>> existing serialised dump mechanism when in non-alt mode? That would be more
>> acceptable to me.
> I had considered this, but then decided to do the change unconditional
> here, as other than for '0', where using tasklets comes with a certain risk,
> 'd' with the change isn't any more dangerous than without. But if making
> this optional is going to help acceptance, I'll modify it accordingly.

The potential for interleaved output is an issue for me. I'll let it slide
if it's only in the alt-key scheme.

 -- Keir

Xen-devel mailing list