WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: RE: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into 'struct xen_netbk'.
From: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>
Date: Tue, 4 May 2010 08:48:00 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy, Steven Smith <steven.smith@xxxxxxxxxx>
Delivery-date: Mon, 03 May 2010 17:49:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100503160239.GB31299@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <D5AB6E638E5A3E4B8F4406B113A5A19A1D94B188@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20100503160239.GB31299@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrq2kU3vJXqdSTXTYSdXeFYX7GGyQASQMlA
Thread-topic: [Xen-devel][Pv-ops][PATCH 1/4 v2] Netback: Generilize static/global variables into 'struct xen_netbk'.
I didn't add the --strict option. I will change it accordingly.

However for +typedef unsigned int pending_ring_idx_t;
this typedef is moved from netback.c, and not the type. 

Thanks,
Dongxiao

Konrad Rzeszutek Wilk wrote:
> On Thu, Apr 29, 2010 at 10:28:18PM +0800, Xu, Dongxiao wrote:
>> Netback: Move global/static variables into struct xen_netbk.
> 
>  scripts/checkpatch.pl --strict
> ~/0001-Netback-Move-global-static-variables-into-struct-xe.patch
> WARNING: do not add new typedefs
> #24: FILE: drivers/xen/netback/common.h:231:
> +typedef unsigned int pending_ring_idx_t;
> 
> CHECK: spinlock_t definition without comment
> #75: FILE: drivers/xen/netback/common.h:282:
> +       spinlock_t net_schedule_list_lock;
> 
> total: 0 errors, 1 warnings, 1 checks, 876 lines checked
> 
> /home/konrad/0001-Netback-Move-global-static-variables-into-struct-xe.patch
> has style problems, please review.  If any of these errors
> are false positives report them to
> 
>> 
>> Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>
> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel