WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Linux PATCH] Make hugepages work in current git tr

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Re: [Linux PATCH] Make hugepages work in current git tree
From: Dave McCracken <dcm@xxxxxxxx>
Date: Fri, 30 Apr 2010 14:34:48 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Fri, 30 Apr 2010 12:36:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BD9FF77.1040300@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100428140825.17161.27594.sendpatchset@xxxxxxxxxxxxxxxxxxx> <201004291643.16613.dcm@xxxxxxxx> <4BD9FF77.1040300@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.12.4 (Linux/2.6.32; KDE/4.3.4; x86_64; ; )
On Thursday 29 April 2010, Jeremy Fitzhardinge wrote:
> On 04/29/2010 02:43 PM, Dave McCracken wrote:
> > On Thursday 29 April 2010, Jeremy Fitzhardinge wrote:
> >> Looks reasonable.  I rewrote the commit comment:
> >>
> >> Subject: [PATCH] x86/hugetlb: use set_pmd for huge pte operations
> >>
> >> On x86, a huge pte is logically a pte, but structurally a pmd.  Among
> >> other issues, pmds and ptes overload some flags for multiple uses (PAT
> >> vs PSE), so it is necessary to know which structural level a pagetable
> >> entry is in order interpret it properly.
> >>
> >> When huge pages are used within a paravirtualized system, it is
> >> therefore appropriate to use the pmd set of function to operate on them,
> >> so that the hypervisor can correctly validate the update.
> >>
> >> Signed-off-by: Dave McCracken <dave.mccracken@xxxxxxxxxx>
> >> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> >>
> >> Does this look correct?
> >
> > Yes, that's an excellent summary of the issue.  Thank you.
> 
> Have you tested this patch on native as well as under Xen?

Yes, it works just fine, though see my separate post about building the current 
git tree without Xen.  I'd forgotten I had to patch it to make it build.

Dave McCracken

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>