WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 6 of 6] PV on HVM suspend\resume

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 6 of 6] PV on HVM suspend\resume
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 23 Apr 2010 16:08:56 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 23 Apr 2010 16:09:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1004221610060.11380@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1004221610060.11380@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4
On 04/22/2010 08:17 AM, Stefano Stabellini wrote:
> +static void do_hvm_suspend(void)
> +{
> +     int err;
> +     int cancelled = 1;
> +
> +     shutting_down = SHUTDOWN_SUSPEND;
> +
> +     err = stop_machine_create();
> +     if (err) {
> +             printk(KERN_ERR "xen suspend: failed to setup stop_machine 
> %d\n", err);
> +             goto out;
> +     }
> +
> +#ifdef CONFIG_PREEMPT
> +     /* If the kernel is preemptible, we need to freeze all the processes
> +        to prevent them from being in the middle of a pagetable update
> +        during suspend. */
> +     err = freeze_processes();
> +     if (err) {
> +             printk(KERN_ERR "xen suspend: freeze failed %d\n", err);
> +             goto out_destroy_sm;
>   

This won't compile with CONFIG_PREEMPT enabled, because out_destroy_sm
is missing below.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel