[Xen-devel] Re: [PATCHv2 3/4] libxl: add version_info function

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>]

On 21/04/10 15:17, Andre Przywara wrote:
> +
> +    xc_version(ctx->xch, XENVER_commandline,&u.xen_commandline);
> +    info->commandline = libxl_sprintf(ctx, u.xen_commandline);
oh actually just missed that; it's important to not include a variable 
as the format string: if for some reason any of this field end up 
containing a %something, it will lead usually to segfault.
can you please replace all:

libxl_sprintf(ctx, ..);

by:

libxl_sprintf(ctx, "%s", ...);

Thanks,
--
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel